Refactor the VLLM model #1453
Merged
Refactor the VLLM model #1453
+227
−350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinPicard
force-pushed
the
refactor_vllm
branch
2 times, most recently
from
eb71b49 to
0b4cb61
Compare
RobinPicard
force-pushed
the
refactor_vllm
branch
from
0b4cb61 to
fabed0e
Compare
rlouf
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #1293
Modify the
VLLMclass to inherit from the baseModelclass and implement the standard interface of models for the v1.0.This PR also creates tests for the
VLLMmodel in thetests/modelsdirectory and remove the previous tests for it intests/generate. As far as I can tell, it does not impactserve.